Escape resource ID in API request path #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shield-9
requested review from
bpjain2004,
chimanjain,
nitesh3108,
prablr79,
rajkumar-palani,
Sakshi-dell,
shefali-malhotra,
meggm,
HarishH-DELL,
adamginna-dell,
cbartoszDell,
bogdanNovikovDell,
Leonard-Dell,
mareksuski-dell and
mdutka-dell
as code owners
It looks like client.DoAndGetResponseBody is not working as expected when id param contains `/`. Example: * Method: GET * URI: platform/15/protocols/nfs/aliases * ID: /example-nfs-alias * Expected: Request sent against `/platform/15/protocols/nfs/aliases/%2Fexample-nfs-alias` * Actual: Request sent against `/platform/15/protocols/nfs/aliases//example-nfs-alias`
|
Branch needs updating and PR info is incomplete. |
|
@shield-9 please ensure unit tests are added for this code change |
|
Is there a real world use case driving this change? |
|
This PR cannot be considered for merging until the checks are successful. Either update or close this PR. The PR is also very old so it may be deleted by end of month if there is no activity. |
donatwork
requested review from
AkshaySainiDell,
donatwork and
santhoshatdell
as code owners
|
@shield-9 Can you please update the PR description? Is there a defect filed? |
|
Old hanging PR closing, please re-open if we need to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission checklist
GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Description of your changes:
It looks like client.DoAndGetResponseBody is not working as expected when id param contains
/.Example
Expected
Request sent to
/platform/15/protocols/nfs/aliases/%2Fexample-nfs-aliasActual
Request sent to
/platform/15/protocols/nfs/aliases//example-nfs-alias